Merged
Conversation
= Before The Patch We'd get the following error from our `pylint` action: ``` ************* Module sdb.pipeline sdb/pipeline.py:132:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) ************* Module sdb.commands.zfs.histograms sdb/commands/zfs/histograms.py:136:8: R1731: Consider using 'max_count = max(max_count, HISTOGRAM_WIDTH_MAX)' instead of unnecessary if block (consider-using-max-builtin) ``` = After the Patch Pylint runs fine with no errors
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 87.69% 87.69% -0.01%
==========================================
Files 63 63
Lines 2577 2576 -1
==========================================
- Hits 2260 2259 -1
Misses 317 317
Continue to review full report at Codecov.
|
mmaybee
approved these changes
Apr 29, 2021
Contributor
mmaybee
left a comment
mmaybee
left a comment
There was a problem hiding this comment.
Sigh, pylint seems a bit pedantic to me sometimes.
prakashsurya
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
= Before The Patch
We'd get the following error from our
pylintaction:= After the Patch
Pylint runs fine with no errors